feat: Include remote_function name in generated cloud function name#2388
Open
TrevorBergeron wants to merge 4 commits intomainfrom
Open
feat: Include remote_function name in generated cloud function name#2388TrevorBergeron wants to merge 4 commits intomainfrom
TrevorBergeron wants to merge 4 commits intomainfrom
Conversation
jialuoo
reviewed
Jan 16, 2026
Contributor
There was a problem hiding this comment.
Following tests failed in e2e, please fix them.
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_with_explicit_name
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_with_explicit_name_reuse
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_w_context_manager_named[session-constructor]
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_named_perists_w_session_cleanup
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_w_context_manager_named[connect-method]
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_clean_up_by_session_id
tswast
previously approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕